Fix bad module dep version in 5.10 #2780
Conversation
|
@swift-ci please test |
|
@luispadron / @keith is there anyway that we can check these earlier? 5.10 was released a while back now, did something else change that needed these to be patched? |
|
we technically didn't need the change here unless there was going to be other natural 5.10 releases |
I was more talking about the other change rather than this one. And doesn't hurt to have this in just in case we do. |
|
sorry which one do you mean? the 6.x one? FWIW something did change with these rules, repos have to declare compatibility on the new version of rules_swift since there were breaking changes, so it wasn't that swift-syntax changed, but if a repo that consumes it wants to use a newer version of rules_swift it would have failed w/o this change. These can technically be patched in the bazel-central-registry repo instead of pushed here, but on main it's nice to land to reduce the patching that has to happen there, and make it easier for folks to test dev versions |
Ah I see, good to know. Thanks. |
This was using the wrong versions for
apple_support. We don't need a new tag here as we'll be patching the bazel-central-registry but fixing in case there is another 5.10 patch