8000 [6.0] Make `SyntaxIndexInTree` public and serializable into a `UInt64` by ahoppen · Pull Request #2603 · swiftlang/swift-syntax · GitHub
[go: up one dir, main page]
Skip to content

[6.0] Make SyntaxIndexInTree public and serializable into a UInt64 #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2024
Merged

[6.0] Make SyntaxIndexInTree public and serializable into a UInt64 #2603

merged 1 commit into from
Apr 13, 2024

Conversation

ahoppen
Copy link
Member
@ahoppen ahoppen commented Apr 12, 2024
  • Explanation: If you have two copies of the same syntax tree within two processes, this allows us to communicate the identifier of a node in one process the the equivalent node in the other process.
  • Scope: Adds new API / makes existing API public
  • Risk: Low, almost purely additive
  • Testing: Added a test case
  • Issue: rdar://126221355
  • Reviewer: @rintaro and @bnbarham on Make SyntaxIndexInTree public and serializable into a UInt64 #2594

@ahoppen
Make SyntaxIndexInTree public and serializable into a UInt64
0a030bd 
If you have two copies of the same syntax tree within two processes, this allows us to communicate the identifier of a node in one process the the equivalent node in the other process.
@ahoppen ahoppen requested a review from bnbarham as a code owner April 12, 2024 22:13
@ahoppen
Copy link
Member Author
ahoppen commented Apr 12, 2024

@swift-ci Please test

@ahoppen ahoppen changed the title Make SyntaxIndexInTree public and serializable into a UInt64 [6.0] Make SyntaxIndexInTree public and serializable into a UInt64 Apr 12, 2024
@ahoppen ahoppen merged commit e6417a2 into swiftlang:release/6.0 Apr 13, 2024
3 checks passed
@ahoppen ahoppen deleted the ahoppen/6.0/serializable-syntax-index-in-tree branch April 15, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham
0