Add an introducer property to DeclGroupSyntax #2539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
bnbarham
commented
Mar 12, 2024
| @@ -72,6 +72,22 @@ public protocol DeclGroupSyntax: SyntaxProtocol, DeclSyntaxProtocol { | |||
| set | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Also open to renaming DeclGroupSyntax if anyone has a better name for it.
There was a problem hiding this comment.
I’m not a huge fan of my suggestion but what this conceptually is, is a DeclWithMembersSyntax, I think. At least that describes the trait IMO.
There was a problem hiding this comment.
That matches the other "With" at least 😅
ahoppen
reviewed
Mar 12, 2024
| @@ -72,6 +72,22 @@ public protocol DeclGroupSyntax: SyntaxProtocol, DeclSyntaxProtocol { | |||
| set | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I’m not a huge fan of my suggestion but what this conceptually is, is a DeclWithMembersSyntax, I think. At least that describes the trait IMO.
9722a71 to
88f7302
Compare
|
@swift-ci please test |
|
@swift-ci Please test Windows |
ahoppen
approved these changes
Mar 12, 2024
It can be useful to grab the introducer of a particular declaration, add a property for this purpose to `DeclGroupSyntax`. Fixes swiftlang#2535. Resolves rdar://124247480.
88f7302 to
49e7930
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to grab the introducer of a particular declaration, add a property for this purpose to
DeclGroupSyntax.Fixes #2535.
Resolves rdar://124247480.