8000 🍒 guard nonisolated(unsafe) by experimental feature by sophiapoirier · Pull Request #2356 · swiftlang/swift-syntax · GitHub
[go: up one dir, main page]
Skip to content

🍒 guard nonisolated(unsafe) by experimental feature #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2023
Merged

🍒 guard nonisolated(unsafe) by experimental feature #2356

merged 2 commits into from
Nov 15, 2023

Conversation

sophiapoirier
Copy link
Contributor

No description provided.

@sophiapoirier sophiapoirier requested a review from hborla November 14, 2023 00:26
@sophiapoirier sophiapoirier mentioned this pull request Nov 14, 2023
Merged
@sophiapoirier sophiapoirier force-pushed the nonisolated-unsafe-globals-guard branch from 140d3b7 to b57568f Compare November 14, 2023 18:44
@sophiapoirier
Copy link
Contributor Author

swiftlang/swift#69833

@swift-ci please test

@sophiapoirier
Copy link
Contributor Author

Explanation: bug fixes and functional completion for static concurrency opt-out mechanism nonisolated(unsafe)
Scope: the scope is corrections to a language change already included behind an experimental feature flag
Issue: none
Risk: low risk given that functionality is guarded behind an experimental feature flag
Testing: unit tests included
Reviewer: @hborla

@sophiapoirier sophiapoirier merged commit 7f41827 into swiftlang:release/5.10 Nov 15, 2023
@sophiapoirier sophiapoirier deleted the nonisolated-unsafe-globals-guard branch November 15, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiapoirier @hborla
0