8000 Verify the gyb-generated files even if --degyb-only is passed by ahoppen · Pull Request #199 · swiftlang/swift-syntax · GitHub
[go: up one dir, main page]

Skip to content

Verify the gyb-generated files even if --degyb-only is passed #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you 8000 agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

ahoppen
Copy link
Member
@ahoppen ahoppen commented Jan 27, 2020

Passing --degyb-only --verify-generated-files should verify that the gyb-generated files are up-to-date without building SwiftSyntax. Currently, this combination doesn’t do anything.

@ahoppen ahoppen requested review from Rostepher and nkcsgexi January 27, 2020 23:25
Copy link
Contributor
@Rostepher Rostepher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems simple enough. Thanks for fixing this!

@ahoppen
Copy link
Member Author
ahoppen commented Jan 27, 2020

@swift-ci Please test

@ahoppen ahoppen merged commit 0cd1fea into swiftlang:master Jan 28, 2020
@ahoppen ahoppen deleted the verify-files-with-degyb-only branch January 28, 2020 17:10
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0