8000 [Continued] Use SHGetKnownFolderPath to get path to localappdata for current user by ShikiSuen · Pull Request #5201 · swiftlang/swift-corelibs-foundation · GitHub
[go: up one dir, main page]
Skip to content

[Continued] Use SHGetKnownFolderPath to get path to localappdata for current user #5201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Continued] Use SHGetKnownFolderPath to get path to localappdata for current user #5201

wants to merge 4 commits into from

Conversation

ShikiSuen
Copy link
@ShikiSuen ShikiSuen commented Apr 17, 2025 •
edited
Loading

This PR continues the PR #4998 since the latter is not actively maintained.

@ShikiSuen ShikiSuen mentioned this pull request Apr 17, 2025
Open
@ShikiSuen
Copy link
Author

cc @compnerd Could you please take a look at this PR to see whether there are anything else to fix?

@ShikiSuen
Copy link
Author

Could anyone please review this?

compnerd
compnerd approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member
@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay. This looks good to me!

@compnerd
Copy link
Member
compnerd commented Jun 2, 2025

@swift-ci please test

@compnerd
Copy link
Member
compnerd commented Jun 2, 2025 
11:32:19  /home/build-user/build/buildbot_linux/none-swift_package_sandbox_linux-x86_64/tests/test-foundation-package/Output/test-foundation-networking-static-stdlib.test.tmp/test-foundation-networking | /home/build-user/build/buildbot_linux/llvm-linux-x86_64/bin/FileCheck /home/build-user/swift-integration-tests/test-foundation-package/test-foundation-networking-static-stdlib.test
11:32:19  # executed command: /home/build-user/build/buildbot_linux/none-swift_package_sandbox_linux-x86_64/tests/test-foundation-package/Output/test-foundation-networking-static-stdlib.test.tmp/test-foundation-networking
11:32:19  # .---command stderr------------
11:32:19  # | generic witness table at 0x55f2db72de98 contains out-of-bounds requirement descriptor 0x11
11:32:19  # `-----------------------------
11:32:19  # error: command failed with exit status: -6

This seems unlikely to be related ... @slavapestov any idea what this might be about?

@compnerd
Copy link
Member
compnerd commented Jun 5, 2025

@swift-ci please test

@ShikiSuen
Copy link
Author

Could anyone please take a look at this PR to see what is going on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShikiSuen @compnerd @stevenbrix
0