utils: adjust the "platform" install rules #81775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Rename `Install-Platform` to `Install-SDK` as it adjusts the SDK layout. This is something that we should work towards minimising and ensuring that the install rules in CMake properly stage the files. In the mean time, this allows us to properly structure the SDK. Alter the parameters to avoid the explicit OS, extracting it from the platform set provided. Additionally provide an SDK identifier to allow us to handle the experimental SDKs as well.
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
Install-PlatformtoInstall-SDKas it adjusts the SDK layout. This is something that we should work towards minimising and ensuring that the install rules in CMake properly stage the files. In the mean time, this allows us to properly structure the SDK.Alter the parameters to avoid the explicit OS, extracting it from the platform set provided. Additionally provide an SDK identifier to allow us to handle the experimental SDKs as well.