8000 Add optional verification to check that tail calls from swifttail->swiftail are marked musttail. by varungandhi-apple · Pull Request #2766 · swiftlang/llvm-project · GitHub
[go: up one dir, main page]
Skip to content

Add optional verification to check that tail calls from swifttail->swiftail are marked musttail. #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2021
Merged

Add optional verification to check that tail calls from swifttail->swiftail are marked musttail. #2766

merged 2 commits into from
Mar 31, 2021

Conversation

varungandhi-apple
Copy link
@varungandhi-apple varungandhi-apple commented Mar 30, 2021 •
edited
Loading

Fixes rdar://75899279 and rdar://76024125

@varungandhi-apple
Use musttail in MergeFunctions for swiftasync->swiftasync tail calls.
285737e 
Fixes rdar://76024125.
@varungandhi-apple
Update musttail verification to check all swiftasync->swiftasync tail…
f652e1b 
… calls.

When -enable-swifttailcc-musttail-check is passed (off by default), we will
check that all swiftasync->swiftasync tail calls are marked musttail.

Fixes rdar://75899279.
@varungandhi-apple
Copy link
Author

@swift-ci test

@varungandhi-apple
Copy link
Author

I will be turning on the setting for Swift compiler and runtime separately, which is why the check is off by default at the moment.

@varungandhi-apple varungandhi-apple merged commit 80c7803 into swiftlang:apple/stable/20210107 Mar 31, 2021
@varungandhi-apple
Copy link
Author
varungandhi-apple commented Mar 31, 2021 •
edited
Loading

@varungandhi-apple varungandhi-apple deleted the vg-apple/stable branch March 31, 2021 18:24
@etcwilde etcwilde mentioned this pull request May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschwaighofer aschwaighofer aschwaighofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varungandhi-apple @aschwaighofer
0

Linux failure is unrelated; merged.