8000 [upstreaming] Revert NFC change to return in ThreadPlanStepInRange::D… by Teemperor · Pull Request #256 · swiftlang/llvm-project · GitHub
[go: up one dir, main page]
Skip to content

[upstreaming] Revert NFC change to return in ThreadPlanStepInRange::D… #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to 8000 our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2019
Merged

[upstreaming] Revert NFC change to return in ThreadPlanStepInRange::D… #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[upstreaming] Revert NFC change to return in ThreadPlanStepInRange::D… 
…efaultShouldStopHereCallback

I'll upstream this change.
  • Loading branch information
@Teemperor
Teemperor committed Nov 11, 2019
commit 3169d099536a86fa34ca4bbc861966b6f19a09ff
2 changes: 1 addition & 1 deletion lldb/source/Target/ThreadPlanStepInRange.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ bool ThreadPlanStepInRange::DefaultShouldStopHereCallback(
should_stop_here = ThreadPlanShouldStopHere::DefaultShouldStopHereCallback(
current_plan, flags, operation, status, baton);
if (!should_stop_here)
return false;
return should_stop_here;

if (should_stop_here && current_plan->GetKind() == eKindStepInRange &&
operation == eFrameCompareYounger) {
Expand Down
0