8000 [SwiftLanguageRuntime] Get rid of some legacy. by dcci · Pull Request #18 · swiftlang/llvm-project · GitHub
[go: up one dir, main page]

Skip to content

[SwiftLanguageRuntime] Get rid of some legacy. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[SwiftLanguageRuntime] Get rid of some legacy.
  • Loading branch information
Davide Italiano committed Oct 23, 2019
commit dd9de7a7017031a4a260a43b6a982c0f90dbedf2
7 changes: 0 additions & 7 deletions lldb/source/Target/SwiftLanguageRuntime.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1983,13 +1983,6 @@ Value::ValueType SwiftLanguageRuntime::GetValueType(
eTypeInstanceIsPointer))
return Value::eValueTypeLoadAddress;
}

if (static_type_flags.AllSet(eTypeIsSwift | eTypeIsPointer) &&
static_type_flags.AllClear(eTypeIsGenericTypeParam)) {
// FIXME: This branch is not covered by any testcases in the test suite.
if (is_indirect_enum_case || static_type_flags.AllClear(eTypeIsBuiltIn))
return Value::eValueTypeLoadAddress;
}
}

// Enabling this makes the inout_variables test hang.
Expand Down
0