8000 Normalize path for LLVM_EXTERNAL_SWIFT_SOURCE_DIR by mhegazy · Pull Request #10949 · swiftlang/llvm-project · GitHub
[go: up one dir, main page]
Skip to content

Normalize path for LLVM_EXTERNAL_SWIFT_SOURCE_DIR #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: stable/20240723
Choose a base branch
from
Open

Normalize path for LLVM_EXTERNAL_SWIFT_SOURCE_DIR #10949

wants to merge 1 commit into from
+3 −2

Conversation

mhegazy
Copy link
@mhegazy mhegazy commented Jul 2, 2025 •
edited
Loading

Since #10935 and #10937 landed, we are seeing failures while configuring llvm-project on Windows CI (see example failure). The root cause is unescaped path separators in LLVM_EXTERNAL_SWIFT_SOURCE_DIR, which leads to CMake configuration errors on Windows.

This PR addresses the issue by using cmake_path to normalize LLVM_EXTERNAL_SWIFT_SOURCE_DIR before it is appended to CMAKE_MODULE_PATH. This ensures 8000 the path is correctly formatted and portable across all supported hosts.

For context, LLVM_EXTERNAL_SWIFT_SOURCE_DIR is used in two places in llvm-project. The other use site leverages include_directories, which already handles path separators correctly on different hosts (see lldb/cmake/modules/LLDBConfig.cmake)

Testing:

  • Confirmed that the change resolves the Windows CI configuration failure.
  • No regressions observed on macOS or Linux builds.

Note: If landed, this change will need to be cherry-picked in next, and release/6.2

@mhegazy mhegazy requested a review from a team as a code owner July 2, 2025 23:44
@compnerd
Copy link
Member
compnerd commented Jul 2, 2025

@swift-ci please test

bulbazord
bulbazord approved these changes Jul 3, 2025
View reviewed changes
Copy link
@bulbazord bulbazord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

This was referenced Jul 3, 2025
Open
Open
@Steelskin
Copy link

@swift-ci please test windows platform

1 similar comment
@Steelskin
Copy link

@swift-ci please test windows platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulbazord bulbazord bulbazord approved these changes

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhegazy @compnerd @Steelskin @bulbazord
0