🍒 [lldb][swift] Fix GetParentIfClosure for Struct/Enum constructors #10938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e066168)
We had a `class` called `MY_STRUCT`. (cherry picked from commit fc9cdb2)
There are two possible variants of constructors: allocating (Kind::Allocator) and initializing (Kind::Constructor). When mangling a closure, the "context" is arbitrarily chosen to be the initializing variant. As such, we need to check both when looking for the parent of a closure. If both exist, `Kind::Constructor` is the one containing user code, so it is always checked first. rdar://154309468 (cherry picked from commit c7c1565)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.