[lldb][swift] Fix GetParentIfClosure for Struct/Enum constructors #10922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a `class` called `MY_STRUCT`.
There are two possible variants of constructors: allocating (Kind::Allocator) and initializing (Kind::Constructor). When mangling a closure, the "context" is arbitrarily chosen to be the initializing variant. As such, we need to check both when looking for the parent of a closure. If both exist, `Kind::Constructor` is the one containing user code, so it is always checked first. rdar://154309468
|
@swift-ci test please |
| return !sc_list.IsEmpty(); | ||
| } | ||
|
|
||
| // There are two possible variants of constructors: allocating (Kind::Allocator) |
There was a problem hiding this comment.
Suggested change
| // There are two possible variants of constructors: allocating (Kind::Allocator) | |
| /// There are two possible variants of constructors: allocating (Kind::Allocator) |
| // As per swift/lib/Demangling/Demangler.cpp, Kind::Constructor is | ||
| // expected to end in `c` and `Kind::Allocator` to end in `C`. This is a | ||
| // cheap way to avoid recreating the mangled tree from scratch. | ||
| if (ctor_kind_mangled_name.back() == 'c') { |
There was a problem hiding this comment.
We already do so many demangle operations when resolving types that I would rather demangle again here rather than hardcode details of the mangling scheme.
There was a problem hiding this comment.
It's not so much about demangling again, it's about reconstructing the entire demangle tree.
There is no "node.setKind", we are forced to rebuild everything, and I don't think there are any convenient APIs today to do this
adrian-prantl
approved these changes
Jun 27, 2025
| init(input: [Int]) { | ||
| let find_me = "hello" | ||
| let _ = input.map { | ||
| return $0 // break_ctor_enum |
There was a problem hiding this comment.
I would write this as
print("break_ctor_enum")
return $0
for more breakpoint stability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.