Return a SwiftArrayEmptyBufferHandler if loc points to an EmptyArray Symbol. #10919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Symbol. If we have a ValueObjectSP who's storage_location points to a S_swiftEmptyArrayStorage symbol, return a SwiftArrayEmptyBufferHandler
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
If we have a ValueObjectSP who's storage_location points to a S_swiftEmptyArrayStorage symbol, return a SwiftArrayEmptyBufferHandler.
Scope:
This affects lldb evaluating a SwiftEmptyArrayStorage on all platforms
Issues:
N/A
Original PRs:
#10920
Risk:
Limited, it only affects printing the contents of a SwiftEmptyArrayStorage type of array
Testing:
Tested locally with a small swift file test case, and also added a test for it called lldb/test/API/lang/swift/swift_empty_arr/TestSwiftGlobalEmptyArray.py which should inform of any breakages in CI
Reviewers:
@adrian-prantl