8000 [lldb] Add extra debugging info to TSan Swift access race test by DanBlackwell · Pull Request #10892 · swiftlang/llvm-project · GitHub
[go: up one dir, main page]
Skip to content

[lldb] Add extra debugging info to TSan Swift access race test #10892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

[lldb] Add extra debugging info to TSan Swift access race test #10892

merged 1 commit into from
Jun 25, 2025

Conversation

DanBlackwell
Copy link

This test has failed once, and this commit adds more detail to the assertion so that any future failures can be more easily diagnosed.

@DanBlackwell
Copy link
Author

@swift-ci test

@adrian-prantl
Copy link

@DanBlackwell There is no point in trying to test on the next branch, the Swift compiler usually doesn't even build. We typically do our Swift-LLDB development on the stable/20240723 or swift/release/6.2 branch (which auto merges into the former) and then manually cherry-pick every commit into next.

@DanBlackwell DanBlackwell changed the base branch from next to swift/release/6.2 June 24, 2025 20:53
@DanBlackwell DanBlackwell requested a review from a team as a code owner June 24, 2025 20:53
@DanBlackwell DanBlackwell changed the base branch from swift/release/6.2 to next June 24, 2025 20:53
@DanBlackwell
[lldb] Add extra debugging info to TSan Swift access race test
78f1103 
This test has failed once, and this commit adds more detail to the assertion so that any future failures can be more easily diagnosed.
@DanBlackwell DanBlackwell force-pushed the tsan-lldb-test-debugging-improvement branch from ab33ffa to 78f1103 Compare June 24, 2025 21:04
@DanBlackwell DanBlackwell changed the base branch from next to swift/release/6.2 June 24, 2025 21:05
@DanBlackwell
Copy link
Author

@swift-ci test

@QuietMisdreavus QuietMisdreavus removed their request for review June 24, 2025 21:08
@adrian-prantl adrian-prantl merged commit 7f4fc84 into swiftlang:swift/release/6.2 Jun 25, 2025
3 checks passed
@DanBlackwell DanBlackwell mentioned this pull request Jun 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-prantl adrian-prantl adrian-prantl approved these changes

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanBlackwell @adrian-prantl
0