🍒[lldb][swift] Disable breakpoint filtering by default #10886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous patch had introduced the notion of Language breakpoint
filtering when setting line breakpoints. While this is generally a good
idea, the swift implementation was motivated by statements like this:
```
async let x = ...
await foo()
await x
```
All of these lines have many different breakpoint locations associated
with them, creating many pauses while stepping; the intent behind the
filtering was to provide a smoother stepping experience.
The implementation filters breakpoints by "funclet" numbers,
disabling all but the lowest such funclet. Unfortunately, this fails
when the CFG of an async funclet needs to be cloned in non-trivial ways.
For example:
```
func foo(_ argument: Int) async {
do {
switch argument {
case 1:
try await willthrow(1)
case 2:
try await willthrow(2)
default:
return
}
} catch {
print("breakhere")
}
}
```
The breakpoint in "breakhere" has two funclets associated with it, one
when we throw from case 1, one from case 2. Filtering is incorrect in
this situation.
This patch disables filtering until we can solve this at a compiler
level. While we are disabling this through the TargetProperties setting,
which could affect other languages, Swift is the only such language
using that setting.
(cherry picked from commit 77290cc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous patch had introduced the notion of Language breakpoint filtering when setting line breakpoints. While this is generally a good idea, the swift implementation was motivated by statements like this:
All of these lines have many different breakpoint locations associated with them, creating many pauses while stepping; the intent behind the filtering was to provide a smoother stepping experience.
The implementation filters breakpoints by "funclet" numbers, disabling all but the lowest such funclet. Unfortunately, this fails when the CFG of an async funclet needs to be cloned in non-trivial ways. For example:
The breakpoint in "breakhere" has two funclets associated with it, one when we throw from case 1, one from case 2. Filtering is incorrect in this situation.
This patch disables filtering until we can solve this at a compiler level. While we are disabling this through the TargetProperties setting, which could affect other languages, Swift is the only such language using that setting.
(cherry picked from commit 77290cc)