[BoundsSafety] Fix dynamic-count-invalid-rhs.c test (NFC) #10871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since recently, Clang does not attach an invalid statement to function body. In the modified test, the function body won't have `p3->len = asdf;` statement. This makes our dynamic count pointer assignment analysis think that the assignment to `p3->len` is missing. We could check `Sema::hasAnyUnrecoverableErrorsInThisFunction()` and not run our analysis if there is any error. But, we still want to diagnose problems in other blocks. I am not sure if there is a good way to check if a given block has already any unrecoverable error. rdar://153756387
|
@swift-ci test llvm |
rapidsna
approved these changes
Jun 24, 2025
|
Merging it to unblock CI. @patrykstefanski Could you please file another radar to track this usability issue caused by Clang recently not attaching an invalid statement to function body? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since recently, Clang does not attach an invalid statement to function body. In the modified test, the function body won't have
p3->len = asdf;statement. This makes our dynamic count pointer assignment analysis think that the assignment top3->lenis missing.We could check
Sema::hasAnyUnrecoverableErrorsInThisFunction()and not run our analysis if there is any error. But, we still want to diagnose problems in other blocks. I am not sure if there is a good way to check if a given block has already any unrecoverable error.rdar://153756387