Moderate Bugfix 18057 #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemant3434
commented
Mar 21, 2021
| venv/ | ||
| bugs.py | ||
| bugs.py |
There was a problem hiding this comment.
Must remove before creating a PR to Scikit learn
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes scikit-learn#18057
What does this implement/fix? Explain your changes.
An improved param selector which selects the param dictionary uniformly and makes sure that the bias towards larger dictionaries is removed
Any other comments?
Utilizes smart range functions which maintains the current Big O complexity of n2 on top of added functionality, instead of generating parameters grids every iteration which is the naïve implementation and results in O(n3).