Fix sanitizeTag to retain numbers and underscore in tag names #4050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbohlool thanks for the contribution and adding various tests to cover the change. |
|
Happy to contribute. How can I get this change into my maven workflow? (sorry not a maven expert), I have plugin version "2.2.2-SNAPSHOT" but it doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For in 8000 stance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)I've run bin/run-all-petstore but there are lots of unrelated changes, and in a glance I could not see any change related to this PR. I am just guessing petstore samples are out of date. Let me know if you want me to add those (huge) changes.
2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
I've changed the pattern sanitizeTag uses to remove invalid characters and also added underscore to tags starting with a number. Also added some test cases.
fixes #2657