8000 feat: dynamic event bindings by flipkickmedia · Pull Request #6876 · sveltejs/svelte · GitHub
[go: up one dir, main page]

Skip to content

feat: dynamic event bindings #6876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/runtime/internal/Component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export interface Fragment {
/* outro */ o: (local: any) => void;
/* destroy */ d: (detaching: 0 | 1) => void;
}

interface T$$ {
dirty: number[];
ctx: null | any;
Expand All @@ -41,6 +42,20 @@ interface T$$ {
root:Element | ShadowRoot
}

/**
* bind_events
* Binds the events provided in options.props, to named callbacks event:bindings
* @param props
*/
function bind_events(props) {
const events = props && props['event:bindings'] ? props['event:bindings'] : {};

if (Object.keys(events).length) {
delete props['event:bindings'];
}
return events;
}

export function bind(component, name, callback) {
const index = component.$$.props[name];
if (index !== undefined) {
Expand Down Expand Up @@ -127,7 +142,7 @@ export function init(component, options, instance, create_fragment, not_equal, p
context: new Map(options.context || (parent_component ? parent_component.$$.context : [])),

// everything else
callbacks: blank_object(),
callbacks: bind_events(options.props),
dirty,
skip_bound: false,
root: options.target || parent_component.$$.root
Expand Down
29 changes: 17 additions & 12 deletions src/runtime/internal/lifecycle.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { custom_event } from './dom';
import {custom_event} from './dom';

export let current_component;

Expand Down Expand Up @@ -27,13 +27,12 @@ export function onDestroy(fn: () => any) {
get_current_component().$$.on_destroy.push(fn);
}

export function createEventDispatcher<
EventMap extends {} = any
>(): <EventKey extends Extract<keyof EventMap, string>>(type: EventKey, detail?: EventMap[EventKey]) => void {
export function createEventDispatcher<EventMap extends {} = any>(): <EventKey extends Extract<keyof EventMap, string>>(type: EventKey, detail?: EventMap[EventKey]) => void {
const component = get_current_component();

return (type: string, detail?: any) => {
const callbacks = component.$$.callbacks[type];
const catchAllBinding = component.$$.callbacks[type];

if (callbacks) {
// TODO are there situations where events could be dispatched
Expand All @@ -43,6 +42,17 @@ export function createEventDispatcher<
fn.call(component, event);
});
}

if (catchAllBinding) {
// in a server (non-DOM) environment?
try {
const event = custom_event(type, detail);
const data = catchAllBinding[1] && Object.prototype.hasOwnProperty.call(catchAllBinding[1], 'data') ? catchAllBinding[1].data : {};
catchAllBinding[0].call(component, event, data);
} catch (e) {
console.warn(`A component was instantiated with invalid on:* configuration - ${e}`);
}
}
};
}

Expand All @@ -59,17 +69,12 @@ export function getAllContexts<T extends Map<any, any> = Map<any, any>>(): T {
}

export function hasContext(key): boolean {
return get_current_component().$$.context.has(key);
return get_current_component().$$.context.has(key);
}

// TODO figure out if we still want to support
// TODO figure out if we still want to support - yes we do :)
// shorthand events, or if we want to implement
// a real bubbling mechanism
export function bubble(component, event) {
const callbacks = component.$$.callbacks[event.type];

if (callbacks) {
// @ts-ignore
callbacks.slice().forEach(fn => fn.call(this, event));
}
component.$$.ctx[0]['event:bindings'][event.type][0](component.$$.ctx[0]['event:bindings'][event.type][1]);
}
0