8000 fix: correctly parse escaped unicode characters in css selector by 7nik · Pull Request #15976 · sveltejs/svelte · GitHub
[go: up one dir, main page]
Skip to content

fix: correctly parse escaped unicode characters in css selector #15976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2025
Merged

fix: correctly parse escaped unicode characters in css selector #15976

merged 1 commit into from
May 24, 2025
+151 −9

Conversation

7nik
Copy link
Contributor
@7nik 7nik commented May 21, 2025

Found in https://discord.com/channels/457912077277855764/1372972353213960232
Specs: https://www.w3.org/TR/CSS22/syndata.html#characters

The unicode sequences (\123) weren't considered that caused falsy css_unused_selector and even css_expected_identifier (#\31 23 is a valid selector of id="123").

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented May 21, 2025

🦋 Changeset detected

Latest commit: 5877d1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-svelte-15976-svelte.vercel.app/

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15976

@7nik
Copy link
Contributor Author
7nik commented May 21, 2025

Outside a string, a backslash followed by a newline stands for itself (i.e., a DELIM followed by a newline).

I couldn't get this behavior triggered in vanilla HTML, so I'm puzzled where it applies.

Rich-Harris
Rich-Harris approved these changes May 24, 2025
View reviewed changes
Copy link
Member
@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Rich-Harris Rich-Harris merged commit 4875cd6 into sveltejs:main May 24, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request May 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7nik @Rich-Harris
0