remove FromAction interface
#15958
remove FromAction interface
#15958
Conversation
|
|
I think this is more than enough in terms of typing...the errors might not be the most descriptive but the important bit imho is that it 890D errors out when it should...a function returning undefined is also probably fine, it just means that if you have a variable that might be undefined it's accepting it like it should. |
See #15933. This makes some progress — a missing required argument now causes a squiggly, albeit in an odd place (it's essentially backwards, inferring the type of the
actionfrom the missing second argument, rather than inferring that the second argument is missing from the type of theaction). This is the most important bit. But other stuff is still incorrect — it infers the type of theno_argattachments from the second argument, instead of objecting to their presence, and() => undefinedis considered a valid second argument in theoptional_argcase which is probably fine but seems odd.I think I've probably reached the limits of my TypeScript knowledge — if anyone else knows how to fix these remaining issues lmk.