8000 fix: reuse already attached attachments in spread attributes by Ocean-OS · Pull Request #15951 · sveltejs/svelte · GitHub
[go: up one dir, main page]
Skip to content

fix: reuse already attached attachments in spread attributes #15951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: reuse already attached attachments in spread attributes #15951

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
049b5a0
fix: reuse already attached attachments from spread attributes
Ocean-OS May 18, 2025
c1932aa
oops
Ocean-OS May 18, 2025
2c45b7e
try this
Ocean-OS May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
oops
  • Loading branch information
@Ocean-OS
Ocean-OS committed May 18, 2025
commit c1932aab1248ffe1ee48334a88c2629bef96a3fb
2 changes: 1 addition & 1 deletion packages/svelte/src/internal/client/dom/elements/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ export function set_attributes(element, prev, next, css_hash, skip_warning = fal
}

for (let symbol of Object.getOwnPropertySymbols(next)) {
if (symbol.description === ATTACHMENT_KEY && !(key in prev)) {
if (symbol.description === ATTACHMENT_KEY && (prev == undefined || !(symbol in prev))) {
attach(element, () => next[symbol]);
}
}
Expand Down
0