10000 chore: reuse is_function helper by Rich-Harris · Pull Request #15467 · sveltejs/svelte · GitHub
[go: up one dir, main page]
Skip to content

chore: reuse is_function helper #15467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

chore: reuse is_function helper #15467

merged 1 commit into from
Mar 10, 2025

Conversation

Rich-Harris
Copy link
Member

I added an is_function method on Binding in #15460. Turns out there's at least one more place we can use it. I also added some TypeScript trickery (thanks for the assist, v0) so that you can type narrowing when you use it

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Mar 7, 2025

⚠️ No Changeset found

Latest commit: ea239e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 7, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15467

@Rich-Harris Rich-Harris merged commit 1c0e240 into main Mar 10, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the reuse-is-function branch March 10, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rich-Harris @trueadm
0