8000 Implement forward directive by Tropix126 · Pull Request #60 · sveltejs/rfcs · GitHub
[go: up one dir, main page]
Skip to content

Implement forward directive #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Implement forward directive #60

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2ecddd0
Implement forward directive
Tropix126 Oct 7, 2021
095fd03
Fix formatting
Tropix126 Oct 7, 2021
8c9553e
Make explanation more clear
Tropix126 Oct 7, 2021
872689e
Update with further thoughts
Tropix126 Oct 7, 2021
76a5e70
Update 0000-forward-directive.md
Tropix126 Oct 7, 2021
f0ee66a
Add overview topic for additional proposal
Tropix126 Oct 8, 2021
36bd82b
fix error in forward:use:internal usage example
Tropix126 Oct 8, 2021
8e4c329
Update RFC to match some discussed ideas.
Tropix126 Oct 8, 2021
a872445
Remove remaining 3 part directive proposal, update actions example
Tropix126 Nov 21, 2021
fc05a12
convert to nullish coalescing in custom classes
Tropix126 Dec 3, 2021
0d79012
Update 0000-forward-directive.md
Tropix126 Feb 8, 2022
c2cb092
update RFC to accommodate for style directives
Tropix126 Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix error in forward:use:internal usage example
  • Loading branch information
@Tropix126
Tropix126 authored Oct 8, 2021
commit 36bd82be54f7ee61dd8e08df83ea17c3ee0d5736
2 changes: 1 addition & 1 deletion text/0000-forward-directive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ This pattern could be similarly applied to actions:
}
</script>

<button forward:use={internalAction}></button>
<button forward:use:internalAction></button>
```

In this example, the `use` directive would be both forwarded to parent context as well as `internalAction` being applied. A possible pitfall would be how the animation API would play into this, as it's unclear how the compiler would deal with multiple animations.
Expand Down
0