8000 feat: Add `config.kit.env.dir` to allow manually setting a directory to search for `.env` files by elliott-with-the-longest-name-on-github · Pull Request #6175 · sveltejs/kit · GitHub
[go: up one dir, main page]
Skip to content

feat: Add config.kit.env.dir to allow manually setting a directory to search for .env files #6175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elliott-with-the-longest-name-on-github merged 4 commits into from
Aug 23, 2022
Merged

feat: Add config.kit.env.dir to allow manually setting a directory to search for .env files #6175

elliott-with-the-longest-name-on-github merged 4 commits into from
Aug 23, 2022

Conversation

@elliott-with-the-longest-name-on-github
Copy link
Contributor
@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github commented Aug 23, 2022

Closes #5995.

Added tests to options and options-2 to test searching both downwards (into the project) and upwards (out of the project, such as into a parent project in a monorepo). Also added an implicit test to options to test the env.publicPrefix setting.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link
changeset-bot bot commented Aug 23, 2022

🦋 Changeset detected

Latest commit: 7fdd375

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Rich-Harris
Rich-Harris approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member
@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for windows tests to pass, but this LGTM

@elliott-with-the-longest-name-on-github
Copy link
Contributor Author
elliott-with-the-longest-name-on-github commented Aug 23, 2022

All good, going to merge with your approval

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github deleted the 5995/config-kit-env-dir branch August 23, 2022 03:55
@github-actions github-actions bot mentioned this pull request Aug 23, 2022
Merged
@ignatiusmb ignatiusmb mentioned this pull request Aug 23, 2022
Merged
5 tasks
@github-actions github-actions bot mentioned this pull request Aug 23, 2022
Closed
@thenbe thenbe mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Take into account vite.config.envDir or provide a kit.env.dir option

3 participants

@elliott-with-the-longest-name-on-github @Rich-Harris
0