8000 feat: use edge-light condition when building for Vercel Edge Runtime by blaine-arcjet · Pull Request #13720 · sveltejs/kit · GitHub
[go: up one dir, main page]
Skip to content

feat: use edge-light condition when building for Vercel Edge Runtime #13720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 18, 2025
Merged

feat: use edge-light condition when building for Vercel Edge Runtime #13720

merged 5 commits into from
Apr 18, 2025

Conversation

blaine-arcjet
Copy link
Contributor
@blaine-arcjet blaine-arcjet commented Apr 16, 2025 •
edited by eltigerchino
Loading

This adds the edge-light condition to the esbuild.build() command used to bundle code for Vercel's Edge Runtime. I noticed that the condition wasn't respected when marking some dependencies as ssr.external even though the packages supported Edge Runtime via the edge-light condition.

This change brings the compilation more in line with Next.js, as it leverages the edge-light condition.

Adding the conditions configuration also requires manually adding module because it is only defaulted if nothing is configured.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
    - I didn't see any tests for the adapters.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Apr 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: d2088a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino added the pkg:adapter-vercel Pertaining to the Vercel adapter label Apr 18, 2025
eltigerchino
eltigerchino reviewed Apr 18, 2025
View reviewed changes
8000
eltigerchino
eltigerchino reviewed Apr 18, 2025
View reviewed changes
eltigerchino
eltigerchino approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member
@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eltigerchino eltigerchino merged commit ee81145 into sveltejs:main Apr 18, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Apr 16, 2025
Merged
@blaine-arcjet blaine-arcjet mentioned this pull request Apr 18, 2025
Open
@blaine-arcjet blaine-arcjet deleted the phated/vercel-edge-light-condition branch April 18, 2025 15:24
@benmccann benmccann mentioned this pull request Apr 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eltigerchino eltigerchino eltigerchino approved these changes

Assignees
No one assigned
Labels
pkg:adapter-vercel Pertaining to the Vercel adapter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blaine-arcjet @eltigerchino
0