chore: improve paraglide #104
Conversation
🦋 Changeset detectedLatest commit: d88f21b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
it would be nice if the injected template code wasn't always appended on every run, though I'm not sure if there's an elegant way to prevent that atm so what we have now will have to do
we could add all of our code inside a div with a special class name and check for that. Although im not sure it's worth the effort.
yea i don't think it is. it only applies to the demo, so I think it's fine in this case |
|
Added a changeset for the sake of trying to get a release to work! |
there were improvements I wanted to apply before it was merged
things to fix:
onclickshouldn't be wrapped in a string<button onclick="{() => switchToLanguage('en')}">en</button><ParaglideJS>component was poorly wrappedlang="ts"is stripped from the<script>tagswitchToLanguageisn't readded on subsequent runscreatePrinterreturn a tuple instead of an object (nicer that we dont have to name the printers twice)additional notes: