feat: Supabase adder #556
feat: Supabase adder #556
Conversation
🦋 Changeset detectedLatest commit: bcf7b1b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Manuel <30698007+manuel3108@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
|
I've added a flawed approach to running scripts within an adder -- it only works within an existing project using pnpm (and if you have I'm thinking a less-flawed approach may be to capture the package manager earlier in the flow and if any |
Why would it only work in a already created package manager that uses pnpm? If its the problem to detect the currently running package manager, we might be able to borrow that code from In the worst case, couldn't we ask the user to select a PM without installing the deps directly in the beginning? Although i would prefer an automatic detections as suggested above. |
|
I've now implemented a different approach. Keen for your thoughts before I proceed any further. Thank you for pointing me to that snippet from Re: my previous comment which upon a re-read was not clear. I don't know enough about package managers to explain why it worked for pnpm, I assume it was due to caching. The experiment was not flawed re: identifying the package manager. It was flawed because it retained the current flow of
|
Did you try Now let's try running it (keep in mind I have never used supabase before) Looks like the condition for On the home page a login page (/auth) is linked, that doesn't seem to exist, thus showing 404. Looks like it has the same condition problem as above. After removing that, i was able to proceed further. Not sure about the notes on the private page. Are they supposed to be visible anywhere once I send them? Edit: Otherwise everything looks good and works as expected, also code-wise. As an FYI, we are currently working on a lot of stuff behind the scenes. We don't expect the adder configuration to change in any noticeable amount, so it should be straightforward to prepare this for a merge once we get there. We will let you know for sure! |
|
Thanks! Swapped to use execute commands, much better. I cannot reproduce the The home page should be untouched unless you pick Re: notes. They should appear as an unordered list directly above the input text box. Is that not working? EDIT: I'm guessing the demo migrations didn't run, if you re-used the same background supabase services but generated the project multiple times that could happen. If you added the helpers just type EDIT: Also keen to see what is in store :) |
|
Just rechecked. Bug was sitting in front of the computer. Didn't realize the auth question was a multiselect. Now everything that happened makes sense. But does that make sense? How would you structure the demo app with multiple logins? Does that even work. |
|
It would be uncommon to choose both basic and magic link but nothing technically stopping it. The magic link flow is the email confirmation flow every time the user logs in. Choosing basic/magic link + OAuth would be pretty common |
|
Hey @mstibbard sorry for the long wait. Thanks for this awesome PR which was a really good starting point for the supabase adder implementation. As I mentioned before, we are currently working on some stuff behind the scenes, which means we are working in a private repo 😆. But it's not going to be private for much longer, that's why i wanted to give you a heads up. Here is what we changed:
We did all of this by patching in your changes, so GH should credit you once this is merged: We hope that you are cool with all those changes, if not please let me know! |
|
@mstibbard We had another thought about my last comment, are you using discord by any chance, so that we discuss a few things in private? Would you mind hitting me up? (manuel3108, you can also find me on the svelte discord) |
|
Sure, I have sent a friend request on discord. I'm in Sydney, Australia so unsure how well timezones will work |
Started working on a Supabase adder
Svelte-Add Tasks
packageManagerto thenextStepsdata object so instructions can be specific.npx supabase initorpnpm supabase init). This needs some thought as currentlysvelte-addonly installs packages after all adders run. Executing a script within an adder would require earlier capture of the user's package manager and (optional) earlier package installationSupabase Adder Tasks
clioption to install Supabase CLI for local development${packageManager} supabase initcommand./supabase/config.tomlwith SvelteKit default dev URL, email templates etc.demooption to include the example/privateroutesclioption is also selected, include examplenotesmigration and form action etc.adminoption to implement a Supabase client w/ Service Role Key in$lib/server/supabase-adminhelpersoption to implement some useful Supabase commands within the user'spackage.jsonauthmulti-select option where the user can choose which auth solutions to add incl.