8000 feat: Lucia Adder by AdrianGonz97 · Pull Request #543 · svelte-add/svelte-add · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Oct 20, 2024. It is now read-only.

feat: Lucia Adder #543

Closed
wants to merge 31 commits into from
Closed

feat: Lucia Adder #543

wants to merge 31 commits into from

Conversation

AdrianGonz97
Copy link
Collaborator
@AdrianGonz97 AdrianGonz97 commented Aug 9, 2024 •
edited
Loading

WIP

  • missing a lot of error handling
  • need to gracefully handle existing user and session tables
  • implement named import merging (e.g. append new import specifiers to existing named imports if the sources match)
  • figure out why comments are not preserved for the app.d.ts modifications
  • still need to implement the logic for hooks.server.ts
  • add a demo option (mainly based off of the SK example from lucia's examples repo)
    • to avoid collisions with existing user logic, the demo is created under a new route /demo
    • it features a combined login/register page (/demo/login) which mirrors the Named Actions examples in the SvelteKit docs, and a logout action
  • link lucia to drizzle, such that when lucia is selected, drizzle also gets selected
    • a confirmation prompt was also added so that it can be ignored
  • db:push for better-sqlite3 is throwing an error. might be a bug in the newest drizzle-kit/orm version?
  • cleanup and test

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Aug 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7b34cf5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented Aug 9, 2024 •
edited
Loading

commit: 7b34cf5

@svelte-add/ast-manipulation

pnpm add https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/ast-manipulation@543

@svelte-add/config

pnpm add https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/config@543

@svelte-add/core

pnpm add https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/core@543

svelte-add

pnpm add https://pkg.pr.new/svelte-add/svelte-add@543

@svelte-add/testing-library

pnpm add https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/testing-library@543

Open in Stackblitz

@AdrianGonz97
Copy link
Collaborator Author

that hooks.server.ts implementation was quite painful to write 😅. this whole PR needs to be cleaned up a bunch once I get it fully working

@benmccann benmccann mentioned this pull request Aug 13, 2024
Closed
@AdrianGonz97 AdrianGonz97 mentioned this pull request Sep 19, 2024
Merged
8 tasks
@benmccann
Copy link
Collaborator

going to close this in favor of adding it in the new repo

@benmccann benmccann closed this Sep 26, 2024
@benmccann benmccann deleted the feat/lucia-adder branch September 26, 2024 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrianGonz97 @benmccann
0