feat: add --default flag
#376
Conversation
🦋 Changeset detectedLatest commit: 0cf331f The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Looks good and works as expected.
Although where I'm not 100% sure about, so let me just think out loud.
The goal of #350 is to minimize the command length and the required selections within the cli.
Consider this command:
npx @svelte-add/tailwindcss --defaultAs of now, this interaction might create two required interactions for the user
- At least one precondition fails
- We could not detect a package manager
So the question arises if --default should implicitly add --skip-preconditions and --skip-install?
On the one side we could argue that with that change we could guarantee the user a zero interaction setup, but he would be missing a lot of the benefits. On the other side, we already only displays these prompts if really required (> 1 failed precondition, no PM detected) so a lot of these cli commands should already be interaction free.
Based on that I would think it's the best to leave the implementation as-is. What do you think?
I think it should be left as-is. |
|
Cool, then we agree! |
Closes #350
This PR adds the
--defaultflag as a shorthand to install the default adder options for missing options.For example, say that we have 2 tailwind options
typographyandforms(assume both have their defaults set tofalse). If we were to run the command like so:the
typographyplugin will still be added as it was manually specified, but theformsplugin will not.