10000 fix(query): ensure that open connection are killed after timeout by avallete · Pull Request #946 · supabase/postgres-meta · GitHub
[go: up one dir, main page]
Skip to content

fix(query): ensure that open connection are killed after timeout #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

fix(query): ensure that open connection are killed after timeout #946

merged 1 commit into from
May 20, 2025
+39 −2

Conversation

avallete
Copy link
Member

Without statement_timeout set, the query_timeout wont always kill the underlying database query connection leading to possible connections exhaustions

@avallete avallete requested review from a team as code owners May 20, 2025 11:12
@avallete avallete force-pushed the fix/query-timeout-connection-closing branch 2 times, most recently from 0125e82 to 9919c68 Compare May 20, 2025 12:34
@coveralls
Copy link
coveralls commented May 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15137718772

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 76.069%
Totals Coverage Status
Change from base Build 15115001758: 0.03%
Covered Lines: 5159
Relevant Lines: 6699
💛 - Coveralls

@avallete
fix(query): ensure that open connection are killed after timeout
5434754 
Without statement_timeout set, the query_timeout wont always
kill the underlying database query connection leading to possible
connections exhaustions
@avallete avallete force-pushed the fix/query-timeout-connection-closing branch from 9919c68 to 5434754 Compare May 20, 2025 12:38
@avallete avallete merged commit 70c38c0 into master May 20, 2025
5 checks passed
@avallete avallete deleted the fix/query-timeout-connection-closing branch May 20, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soedirgo soedirgo soedirgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avallete @coveralls @soedirgo
0