8000 Add steps to upload Docker image to ECR by thebengeu · Pull Request #156 · supabase/postgres-meta · GitHub
[go: up one dir, main page]

Skip to content

Add steps to upload Docker image to ECR #156

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Add steps to upload Docker image to ECR #156

merged 1 commit into from
Nov 1, 2021

Conversation

thebengeu
Copy link
Member

No description provided.

@thebengeu thebengeu requested review from darora and soedirgo October 29, 2021 08:02
Copy link
Member
@soedirgo soedirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you've checked that the secrets are set feel free to merge 👍

@thebengeu
Copy link
Member Author

I don't recall having to set the secrets for https://github.com/supabase/storage-api/blob/master/.github/workflows/push-to-ecr.yml, I think that they are organisation-level secrets?

@soedirgo
Copy link
Member

Huh, apparently it's a thing https://github.blog/changelog/2020-05-14-organization-secrets/. Feel free to merge then 🙏

@thebengeu thebengeu merged commit ea1c553 into master Nov 1, 2021
@thebengeu thebengeu deleted the feat/ecr branch November 1, 2021 04:54
@github-actions
Copy link
github-actions bot commented Nov 1, 2021

🎉 This PR is included in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

avallete pushed a commit that referenced this pull request May 13, 2025
Add steps to upload Docker image to ECR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0