8000 Release by soedirgo · Pull Request #148 · supabase/postgres-meta · GitHub
[go: up one dir, main page]
Skip to content

Release #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 11, 2021
Merged

Release #148

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b4d256
chore: change some thingamajig
soedirgo Sep 7, 2021
287b74e
fix(lib/triggers): make fields optional for update
soedirgo Sep 9, 2021
562b46c
chore: minor changes to tsconfigs
soedirgo Sep 9, 2021
c1cf4cc
chore: migrate tests to jest
soedirgo Sep 9, 2021
4743d45
chore: fix test getting stuck on Actions
soedirgo Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(lib/triggers): make fields optional for update 
Also some refactors.
  • Loading branch information
@soedirgo
soedirgo committed Sep 9, 2021
commit 287b74efc4a09732a08b6f814cd42b0587ef4aa9
60 changes: 32 additions & 28 deletions src/lib/PostgresMetaTriggers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,55 +150,59 @@ export default class PostgresMetaTriggers {
async update(
id: number,
{
name: newName,
name,
enabled_mode,
}: {
name: string
enabled_mode: 'ORIGIN' | 'REPLICA' | 'ALWAYS' | 'DISABLED'
name?: string
enabled_mode?: 'ORIGIN' | 'REPLICA' | 'ALWAYS' | 'DISABLED'
}
): Promise<PostgresMetaResult<PostgresTrigger>> {
const { data: triggerRecord, error } = await this.retrieve({ id })

const { data: old, error } = await this.retrieve({ id })
if (error) {
return { data: null, error }
}

let enabledModeSql
const enabledMode = enabled_mode.toUpperCase()
const { name: currentName, schema: schema, table: table } = triggerRecord!
const qualifiedTableName = `${ident(schema)}.${ident(table)}`
const updateNameSql =
newName && newName !== currentName
? `ALTER TRIGGER ${ident(currentName)} ON ${qualifiedTableName} RENAME TO ${ident(
newName
)};`
: ''

if (['ORIGIN', 'REPLICA', 'ALWAYS', 'DISABLED'].includes(enabledMode)) {
if (enabledMode === 'DISABLED') {
enabledModeSql = `ALTER TABLE ${qualifiedTableName} DISABLE TRIGGER ${ident(currentName)};`
} else {
enabledModeSql = `ALTER TABLE ${qualifiedTableName} ENABLE ${
['REPLICA', 'ALWAYS'].includes(enabledMode) ? enabledMode : ''
} TRIGGER ${ident(currentName)};`
}
let enabledModeSql = ''
switch (enabled_mode) {
case 'ORIGIN':
enabledModeSql = `ALTER TABLE ${ident(old!.schema)}.${ident(
old!.table
)} ENABLE TRIGGER ${ident(old!.name)};`
break
case 'DISABLED':
enabledModeSql = `ALTER TABLE ${ident(old!.schema)}.${ident(
old!.table
)} DISABLE TRIGGER ${ident(old!.name)};`
break
case 'REPLICA':
case 'ALWAYS':
enabledModeSql = `ALTER TABLE ${ident(old!.schema)}.${ident(
old!.table
)} ENABLE ${enabled_mode} TRIGGER ${ident(old!.name)};`
break
default:
break
}
const nameSql =
name && name !== old!.name
? `ALTER TRIGGER ${ident(old!.name)} ON ${ident(old!.schema)}.${ident(
old!.table
)} RENAME TO ${ident(name)};`
: ''

// updateNameSql must be last
const sql = `BEGIN; ${enabledModeSql} ${updateNameSql} COMMIT;`

const sql = `BEGIN; ${enabledModeSql}; ${nameSql}; COMMIT;`
{
const { error } = await this.query(sql)

if (error) {
return { data: null, error }
}
}

return await this.retrieve({ id })
}

async remove(id: number, { cascade = false }): Promise<PostgresMetaResult<PostgresTrigger>> {
async remove(id: number, { cascade = false } = {}): Promise<PostgresMetaResult<PostgresTrigger>> {
const { data: triggerRecord, error } = await this.retrieve({ id })

if (error) {
Expand Down
0