feat(/functions): adds POST /functions, DELETE /functions and PATCH /functions #118
Conversation
implements missing routes and (POST & DELETE) supabase#115
Currently only supports changing function name. Working on changing function name, extensions and schema at once supabase#115
There was a problem hiding this comment.
@i-pip awesome job on the PR so far! Left you a couple of comments. Please let me know if you have any questions or concerns regarding my review and I'll be here to answer. We would love to merge in these changes as soon as possible!
|
Thank you for all the feedback @w3b6x9 🙌 making the requested changes now - I love it here! |
There was a problem hiding this comment.
@i-pip thank you so much for your quick changes to my previous review. I left you some more comments with change requests. Again, please don't hesitate to reach out if anything comes up and thanks for your patience.
Also, checklist was just added to the README. Since you did all the hard work, feel free to rebase develop and check off functions as part of your PR!
| @@ -14,15 +14,15 @@ console.log('Running tests on ', URL) | |||
| describe('/', () => { | |||
| it('GET', async () => { | |||
| const res = await axios.get(`${URL}/`) | |||
| assert.equal(res.status, STATUS.SUCCESS) | |||
| assert.equal(!!res.data.version, true) | |||
| assert.strictEqual(res.status, STATUS.SUCCESS) | |||
There was a problem hiding this comment.
@i-pip thanks for updating all of these to strictEqual!
|
🎉 This PR is included in version 0.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
feat(/functions): adds POST /functions, DELETE /functions and PATCH /functions
Implements missing methods (POST & DELETE)
What kind of change does this PR introduce?
What is the current behavior?
Currently list and get methods are implemented on /functions route - #115
What is the new behavior?
Adds POST /functions (implemented by create method) and DELETE /functions (implemented by remove)
Function properties that can be changed