8000 Add index_advisor extension to image by olirice · Pull Request #933 · supabase/postgres · GitHub
[go: up one dir, main page]

Skip to content

Add index_advisor extension to image #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Add index_advisor extension to image #933

merged 9 commits into from
Apr 8, 2024

Conversation

olirice
Copy link
Contributor
@olirice olirice commented Apr 3, 2024

Adds the index_advisor extension for LW11 index advisor report feature.

@olirice olirice marked this pull request as ready for review April 5, 2024 19:10
@olirice olirice requested review from a team as code owners April 5, 2024 19:10
Copy link
Collaborator
@samrose samrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but I wasn't 100% sure if this error is the result of a syntax problem in the dockerfile? https://github.com/supabase/postgres/actions/runs/8574463100/job/23501349016?pr=933#step:8:230

@olirice
Copy link
Contributor Author
olirice commented Apr 5, 2024

It's been happening in other branches too. I think its unrelated but supabase/backend will know when they review

@samrose samrose self-requested a review April 5, 2024 20:00
Copy link
Contributor
@darora darora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, the test failure you're seeing right now is almost certainly tied to some infra changes to our testing environment.

@olirice olirice merged commit fe4129d into develop Apr 8, 2024
@olirice olirice deleted the or/index-advisor branch April 8, 2024 19:51
damonrand pushed a commit to cepro/postgres that referenced this pull request Jun 15, 2025
* add index_advisor extension to image

* bump image for testing on staging

* remove -source from target COPY

* add index_advisor to supautils allow list

* bump image name for staging

* update nix to include index_advisor + a smoke test

* remove RC tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0