8000 chore: remove pgbouncer from docker aio image [GEN-8039] by bmpandrade · Pull Request #907 · supabase/postgres · GitHub
[go: up one dir, main page]
Skip to content

chore: remove pgbouncer from docker aio image [GEN-8039] #907 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2024
Merged

chore: remove pgbouncer from docker aio image [GEN-8039] #907

merged 2 commits into from
Mar 14, 2024

Conversation

bmpandrade
Copy link
Contributor
@bmpandrade bmpandrade commented Mar 14, 2024 •
edited
Loading

Removes pgbouncer from Docker AIO image.

Also adds some conditionals around healthcheck.sh to avoid running checks when gotrue/fail2ban are disabled.

@bmpandrade bmpandrade requested review from a team as code owners March 14, 2024 12:07
tomashley
tomashley approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor
@tomashley tomashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane

olirice
olirice approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor
@olirice olirice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bmpandrade bmpandrade merged commit d0bca07 into develop Mar 14, 2024
@bmpandrade bmpandrade deleted the bma/remove-pgbouncer-docker-only branch March 14, 2024 17:57
@bmpandrade bmpandrade changed the title chore: remove pgbouncer from docker aio image chore: remove pgbouncer from docker aio image [GEN-8039] Mar 14, 2024
@notion-workspace Notion Workspace
Copy link

Get rid of pgbouncer on Fly

bmpandrade added a commit that referenced this pull request Mar 20, 2024
@bmpandrade
Revert "chore: remove pgbouncer from docker aio image (#907)"
ebed323 
This reverts commit d0bca07.
@bmpandrade bmpandrade mentioned this pull request Mar 20, 2024
Merged
pcnc pushed a commit that referenced this pull request Mar 21, 2024
@bmpandrade @darora
Revert "chore: remove pgbouncer from docker aio image [GEN-8039]" (#912)
33c7533 
* Revert "chore: remove pgbouncer from docker aio image (#907)"

This reverts commit d0bca07.

* fix: bump version to 15.1.1.27 as .26 was disabled due to Fly issues with docker aio

* Update common.vars.pkr.hcl

---------

Co-authored-by: Div Arora <darora@users.noreply.github.com>
@bmpandrade bmpandrade mentioned this pull request Mar 22, 2024
Closed
samrose pushed a commit that referenced this pull request Apr 1, 2024
@bmpandrade @darora @samrose
Revert "chore: remove pgbouncer from docker aio image [GEN-8039]" (#912)
2410b13 
* Revert "chore: remove pgbouncer from docker aio image (#907)"

This reverts commit d0bca07.

* fix: bump version to 15.1.1.27 as .26 was disabled due to Fly issues with docker aio

* Update common.vars.pkr.hcl

---------

Co-authored-by: Div Arora <darora@users.noreply.github.com>
damonrand pushed a commit to cepro/postgres that referenced this pull request Jun 15, 2025
@bmpandrade
chore: remove pgbouncer from docker aio image (supabase#907)
ace486d 
* chore: docker aio - clean fail2ban and gotrue disabled flags/code

* chore: remove pgbouncer from docker AIO image.
damonrand pushed a commit to cepro/postgres that referenced this pull request Jun 15, 2025
@bmpandrade @darora
Revert "chore: remove pgbouncer from docker aio image [GEN-8039]" (su…
794eed7 
…pabase#912)

* Revert "chore: remove pgbouncer from docker aio image (supabase#907)"

This reverts commit d0bca07.

* fix: bump version to 15.1.1.27 as .26 was disabled due to Fly issues with docker aio

* Update common.vars.pkr.hcl

---------

Co-authored-by: Div Arora <darora@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomashley tomashley tomashley approved these changes

@olirice olirice olirice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmpandrade @tomashley @olirice
0