chore: fly fixes; PITR + logging + shutdown + perms #665
Conversation
docker/all-in-one/Dockerfile
Outdated
| @@ -230,4 +230,6 @@ HEALTHCHECK --interval=3s --timeout=2s --start-period=4s --retries=10 CMD [ "hea | |||
|
|
|||
| COPY docker/all-in-one/init /init | |||
| COPY docker/all-in-one/entrypoint.sh /usr/local/bin/ | |||
| COPY docker/all-in-one/postgres-entrypoint.sh /usr/local/bin/ | |||
| COPY docker/all-in-one/shutdown.sh /usr/local/bin/supa-shutdown | |||
There was a problem hiding this comment.
any reason not to preserve the .sh ext?
There was a problem hiding this comment.
no reason - will add extension
| @@ -0,0 +1,60 @@ | |||
| #!/bin/sh | |||
|
|
|||
There was a problem hiding this comment.
Let's give a brief overview of what the script does
docker/all-in-one/shutdown.sh
Outdated
|
|
||
| supervisorctl stop postgresql | ||
|
|
||
| # Postgres ships the latest WAL file using archive_commAND during shutdown, in a blocking operation |
There was a problem hiding this comment.
| # Postgres ships the latest WAL file using archive_commAND during shutdown, in a blocking operation | |
| # Postgres ships the latest WAL file using archive_command during shutdown, in a blocking operation |
| @@ -31,3 +31,5 @@ log_rotation_size = 0 # Automatic rotation of logfiles will | |||
| # or size-driven rotation. Default is | |||
| # off, meaning append to existing files | |||
| # in all cases. | |||
|
|
|||
| log_disconnections = on # log end of a session, including duration | |||
There was a problem hiding this comment.
Yes.
This param is disabled by default and can't track disconnections any other way since the connections are terminated and thus not available in pg_stat_activity.
This allows the shutdown script to track when the last disconnection happened and shutdown the machine after X minutes.
Postgres output related to disconnections is filtered out by Vector, so it won't additionally be shipped to Logflare.
This approach diverges the configs, thus we could have the shutdown script run an ALTER SYSTEM at startup to set log_disconnections to on, since it's a shutdown script dependency after all.
docker/all-in-one/entrypoint.sh
Outdated
|
|
||
| if [ "${INIT_PAYLOAD_PRESIGNED_URL:-}" ]; then | ||
| curl -sSL "$INIT_PAYLOAD_PRESIGNED_URL" -o "$INIT_PAYLOAD_PATH" | ||
| curl -sSL "$INIT_PAYLOAD_PRESIGNED_URL" -o "/tmp/payload.tar.gz" |
docker/all-in-one/entrypoint.sh
Outdated
| if [ "${DATA_VOLUME_MOUNTPOINT}" ]; then | ||
| LOGS_FOLDER="${DATA_VOLUME_MOUNTPOINT}/logs" | ||
|
|
||
| mkdir -p "${LOGS_FOLDER}/postgresql" |
There was a problem hiding this comment.
could be a loop over postgresql, services, wal-g, but this is fine too
There was a problem hiding this comment.
fair point - refactored into a loop
* chore: remove folder creation * trigger build * trigger build * chore: reorder symlinks * chore: fly fixes; PITR + logging + shutdown + perms * chore: rename shutdown script; refactoring
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.