8000 feat: do not enable pgjwt by default in pg 15 by samrose · Pull Request #1592 · supabase/postgres · GitHub
[go: up one dir, main page]
Skip to content

feat: do not enable pgjwt by default in pg 15 #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 17, 2025
Merged

feat: do not enable pgjwt by default in pg 15 #1592

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3fa10bf
feat: do not enable pgjwt by default in pg 15
samrose May 12, 2025
b0b5096
fix: available, but not enabled pgjwt fixes (should still be controll…
samrose May 15, 2025
a86ec22
test: schema test update
samrose May 15, 2025
5e1b74e
chore: test version bump
samrose May 16, 2025
a5c0bc2
feat: bump version
delgado3d May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: do not enable pgjwt by default in pg 15
  • Loading branch information
@samrose
samrose committed May 15, 2025
commit 3fa10bf08be4a096a7c059006ce71a6145849ac4
12 changes: 12 additions & 0 deletions ansible/tasks/stage2-setup-postgres.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
- name: Check if psql_version is psql_17
set_fact:
is_psql_17: "{{ psql_version in ['psql_17'] }}"

- name: Check if psql_version is psql_15
set_fact:
is_psql_15: "{{ psql_version in ['psql_15'] }}"

- name: Remove specified extensions from postgresql.conf if orioledb-17 or 17 build
ansible.builtin.command:
Expand All @@ -30,6 +34,14 @@
when: is_psql_oriole or is_psql_17 and stage2_nix
become: yes

- name: Remove pgjwt from supautils.conf if 15 build
ansible.builtin.command:
cmd: >
sed -i 's/ pgjwt,//g'
/etc/postgresql-custom/supautils.conf
when: is_psql_15 and stage2_nix
become: yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Can this be tried locally?

If not, we're planning to remove ansible later right?

Copy link
Collaborator Author
@samrose samrose May 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steve-chavez yes we are planning to remove ansible later. This can be tried locally, and will be part of our local testing env I'll add a change for that in this PR.

I am starting with the auth project to migrate package and config steps out of ansible. Then likely postgres will be next, fwiw.


- name: Remove db_user_namespace from postgresql.conf if orioledb-17 or 17 build
ansible.builtin.command:
cmd: >
Expand Down
6 changes: 3 additions & 3 deletions ansible/vars.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ postgres_major:

# Full version strings for each major version
postgres_release:
postgresorioledb-17: "17.0.1.080-orioledb"
postgres17: "17.4.1.030"
postgres15: "15.8.1.087"
postgresorioledb-17: "17.0.1.078-orioledb-pgjwt15-1"
postgres17: "17.4.1.028-pgjwt15-1"
postgres15: "15.8.1.085-pgjwt15-1"

# Non Postgres Extensions
pgbouncer_release: "1.19.0"
Expand Down
0