feat: for schema tests, try to use pg_dump #1562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4e3784 to
86e4595
Compare
steve-chavez
approved these changes
Apr 22, 2025
soedirgo
added a commit
that referenced
this pull request
Apr 23, 2025
Trailing whitespace were somehow added in #1562; probably different handling between dbmate and pg_dump
soedirgo
added a commit
that referenced
this pull request
Apr 24, 2025
* fix: grant Vault privs to service_role * adjust tests according to the fix * chore: bump versions * fix: missing Vault privileges for postgres * fix: also privs in the migration * test: schema snapshots changed Trailing whitespace were somehow added in #1562; probably different handling between dbmate and pg_dump --------- Co-authored-by: steve-chavez <stevechavezast@gmail.com>
damonrand
pushed a commit
to cepro/postgres
that referenced
this pull request
Jun 15, 2025
* feat: for schema tests, try to use pg_dump * feat: use pg_dump generated schemas
damonrand
pushed a commit
to cepro/postgres
that referenced
this pull request
Jun 15, 2025
* fix: grant Vault privs to service_role * adjust tests according to the fix * chore: bump versions * fix: missing Vault privileges for postgres * fix: also privs in the migration * test: schema snapshots changed Trailing whitespace were somehow added in supabase#1562; probably different handling between dbmate and pg_dump --------- Co-authored-by: steve-chavez <stevechavezast@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
dbmate works for generating new migrations, but it causes problems for generating schema dumps
This PR attempts to switch to using pg_dump to generate the schemas, which are only used for testing idempotency of the migrations in ci. pg_dump likely will be good enough for that.