Fix matplotlib / pandas 0.21 bug in examples #2336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we manually register the pandas matplotlib converters so people doing manual plotting with pandas works under pandas 0.21
|
Hello @Cadair! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on November 08, 2017 at 22:04 Hours UTC |
nabobalis
approved these changes
Nov 8, 2017
|
There is also and the official matplotlib advice https://matplotlib.org/faq/howto_faq.html#plot-numpy-datetime64-values |
wafels
approved these changes
Nov 8, 2017
There was a problem hiding this comment.
Note that the matplotlib advice https://matplotlib.org/faq/howto_faq.html#plot-numpy-datetime64-values also works.
|
Example fail again: https://github.com/sunpy/sunpy/blob/master/examples/AIA_limb_STEREO.py#L63 Why hasn't this been caught before? |
|
@wafels that error is a result of a VSO download error, I have restarted it. |
|
Try block gets a +1 |
|
@nabobalis this too needs backporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we manually register the pandas matplotlib converters so people doing manual plotting with pandas works under pandas 0.21