8000 Add EditorExtension by alexander-schranz · Pull Request #21 · sulu/web-twig · GitHub
[go: up one dir, main page]
Skip to content

Add EditorExtension #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2020
Merged

Add EditorExtension #21

merged 2 commits into from
Jan 16, 2020

Conversation

alexander-schranz
Copy link
Member
@alexander-schranz alexander-schranz commented Jan 11, 2020 •
edited
Loading

This will add a editor and editor_classes twig filter.

editor

Will wrap the given html with a div with a specific class.

editor_classes

Will add classes to specific tags.

@alexander-schranz alexander-schranz self-assigned this Jan 11, 2020
@alexander-schranz alexander-schranz force-pushed the feature/editor-twig-extension branch 3 times, most recently from 408eec8 to 73f60ad Compare January 11, 2020 16:22
@alexander-schranz
Copy link
Member Author
alexander-schranz commented Jan 11, 2020 •
edited
Loading

Failing tests has nothing todo with this PR the IntlExtension doesn't work like expected see: symfony/symfony#35309. Fixed in #22

alexander-schranz
alexander-schranz commented Jan 11, 2020
View reviewed changes
src/EditorExtension.php
{
return [
new TwigFilter('editor', [$this, 'editor'], ['is_safe' => ['html']]),
new TwigFilter('editor_classes', [$this, 'editorClasses'], ['is_safe' => ['html']]),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better naming suggestions welcome. /cc @luca-rath @thomasduenser @Quehnie @marcostastny @mfehr94 @mscharl @sabinebaer ...

@alexander-schranz alexander-schranz force-pushed the feature/editor-twig-extension branch from 73f60ad to de68e12 Compare January 12, 2020 03:31
luca-rath
luca-rath suggested changes Jan 12, 2020
View reviewed changes
@luca-rath
Copy link
Contributor

@alexander-schranz what do you think of something like symfony's trans_default_domain to set the defaults for editor a 8000 nd editor_classes filters per template? Maybe editor_default_args('div', 'editor') and editor_default_classes({ul: 'list'})?

luca-rath
luca-rath approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor
@luca-rath luca-rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexander-schranz
Copy link
Member Author

@luca-rath would be interesting but sadly not sure how the trans_default_domain works that it is really context based.

@alexander-schranz alexander-schranz force-pushed the feature/editor-twig-extension branch from e6d4655 to 619b1a7 Compare January 13, 2020 13:29
@alexander-schranz alexander-schranz merged commit 1da1e34 into sulu:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luca-rath luca-rath luca-rath approved these changes

Assignees

@alexander-schranz alexander-schranz

@luca-rath luca-rath

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-schranz @luca-rath
0