Fix UserProvider PHPStan Generic update for PasswordUpgraderInterface #7872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,7 +126,7 @@ public function supportsClass($class): bool | |||
|
|
|||
| public function upgradePassword(PasswordAuthenticatedUserInterface $user, string $newHashedPassword): void | |||
| { | |||
| if (!$user instanceof User) { // @phpstan-ignore-line we can not be 100% sure about this but generic forces us to check | |||
There was a problem hiding this comment.
Interesting is we didn't here either not trust the PHPStan generic and added a check already.
|
This is related to #7743 In more modern version Symfony doesn't need a salt and this means a different interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove generic definitions for PasswordUpgraderInterface as it was removed from Symfony core.
Why?
Not longer generic: symfony/symfony#51283