README: response handling #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca2e800 to
d0d795b
Compare
remi-stripe
approved these changes
May 12, 2020
README.md
Outdated
| customer = stripe.Customer.retrieve("cus_123456789") | ||
|
|
||
| # print that customer's email | ||
| print (customer.email) |
8000
richardm-stripe
force-pushed
the
richardm-readme-handling-responses
branch
from
May 12, 2020 17:27
d0d795b to
d9a2c2c
Compare
remi-stripe
approved these changes
May 12, 2020
|
Thanks, @richardm-stripe, this definitely improves the README! I personally still like to have a little extra info about the specific response type (especially since Python doesn’t give you any additional hints in the code)—in this case a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries
Attempt at clarifying how to handle responses, as suggested by @mrcoles in #653
I considered explaining
as @mrcoles suggests,
But the details here are pretty complicated and it's been a challenge to describe them in a way that isn't either misleading or potentially confusing. My hope is that accessing some properties on the example will show users how they can grab properties, and will be enough of a hint to discerning users that these aren't plain dicts as you might otherwise expect.