Support AIOHTTPClient init without running event loop #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Lazily instantiates and caches an aiohttp `ClientSession` at the points that it is actually used so that `AIOHTTPClient` can be initialized without a running event loop (e.g. when setting `stripe.default_http_client = stripe.AIOHTTPClient()` at the top level of a module).
Fixes a type checking error by having `AIOHTTPClient`'s `_session` property assert that the `aiohttp` module exists
The `functools.cached_property` decorator did not exist in Python 3.7, so `AIOHTTPClient`'s `_session` has been changed into a regular property that performs caching manually by storing the `ClientSession` object as a member of the instance.
|
I fixed the typing errors and removed the usage of the |
Ensures `AIOHTTPClient`'s `_cached_session` attribute is defined in the initializer.
|
@richardm-stripe: Bump. |
|
This looks good to me! It will be in Thursday's beta release. Sorry for the silence on this, I appreciate the bump. Thank you for teaching me about about |
richardm-stripe
approved these changes
Mar 20, 2024
richardm-stripe
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Support AIOHTTPClient init without running event loop Lazily instantiates and caches an aiohttp `ClientSession` at the points that it is actually used so that `AIOHTTPClient` can be initialized without a running event loop (e.g. when setting `stripe.default_http_client = stripe.AIOHTTPClient()` at the top level of a module). * Format * Assert aiohttp module is present in AIOHTTPClient Fixes a type checking error by having `AIOHTTPClient`'s `_session` property assert that the `aiohttp` module exists * Remove dependence on cached_property The `functools.cached_property` decorator did not exist in Python 3.7, so `AIOHTTPClient`'s `_session` has been changed into a regular property that performs caching manually by storing the `ClientSession` object as a member of the instance. * Define aiohttp cached session attribute in init Ensures `AIOHTTPClient`'s `_cached_session` attribute is defined in the initializer.
richardm-stripe
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Support AIOHTTPClient init without running event loop Lazily instantiates and caches an aiohttp `ClientSession` at the points that it is actually used so that `AIOHTTPClient` can be initialized without a running event loop (e.g. when setting `stripe.default_http_client = stripe.AIOHTTPClient()` at the top level of a module). * Format * Assert aiohttp module is present in AIOHTTPClient Fixes a type checking error by having `AIOHTTPClient`'s `_session` property assert that the `aiohttp` module exists * Remove dependence on cached_property The `functools.cached_property` decorator did not exist in Python 3.7, so `AIOHTTPClient`'s `_session` has been changed into a regular property that performs caching manually by storing the `ClientSession` object as a member of the instance. * Define aiohttp cached session attribute in init Ensures `AIOHTTPClient`'s `_cached_session` attribute is defined in the initializer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazily instantiates and caches an aiohttp
ClientSessionat the points in time that it is actually used so thatAIOHTTPClientcan be initialized without a running event loop (e.g. when settingstripe.default_http_client = stripe.AIOHTTPClient()at the top level of a module).Related to issue #327.