8000 Even more type annotations by richardm-stripe · Pull Request #1088 · stripe/stripe-python · GitHub
[go: up one dir, main page]
Skip to content

Even more type annotations #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 18, 2023
Merged

Even more type annotations #1088

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3d71a29
__init__.py
richardm-stripe Oct 17, 2023
c32bd57
Type stripe_response
richardm-stripe Oct 17, 2023
868c875
More types on stripe_object
richardm-stripe Oct 17, 2023
bfadc54
Define api_requestor fields
richardm-stripe Oct 17, 2023
8aec1de
Types for error.py
richardm-stripe Oct 17, 2023
7fdcaf0
Fix types
richardm-stripe Oct 18, 2023
0e73623
We aren't ready to release types yet
richardm-stripe Oct 18, 2023
ac58c24
Fix lint
richardm-stripe Oct 18, 2023
a072ac0
stripe_object -> strict
richardm-stripe Oct 18, 2023
e9742a7
More full types for stripe_object
richardm-stripe Oct 18, 2023
07cdabd
We still aren't ready to release types
richardm-stripe Oct 18, 2023
a1b479c
Aurgh
richardm-stripe Oct 18, 2023
9e556ea
Address review comments
richardm-stripe Oct 18, 2023
529f12a
Format
richardm-stripe Oct 18, 2023
fe02fb0
Merge branch 'richardm-more-types-2' into richardm-more-types-3
richardm-stripe Oct 18, 2023
206f86b
Merge branch 'master' into richardm-more-types-3
richardm-stripe Oct 18, 2023
067ab1b
Address code review
richardm-stripe Oct 18, 2023
710f039
Can't import types from typeshed
richardm-stripe Oct 18, 2023
4885d22
Merge branch 'master' into richardm-more-types-3
richardm-stripe Oct 18, 2023 8000
473ca50
Fix unintended behavior change
richardm-stripe Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Can't import types from typeshed
  • Loading branch information
@richardm-stripe
richardm-stripe committed Oct 18, 2023
commit 710f039473e807a83f188e20bd65051b2a23b9e1
3 changes: 1 addition & 2 deletions stripe/stripe_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# pyright: strict
from _typeshed import SupportsKeysAndGetItem
import datetime
import json
from copy import deepcopy
Expand Down Expand Up @@ -115,7 +114,7 @@ def last_response(self) -> Optional[StripeResponse]:

# StripeObject inherits from `dict` which has an update method, and this doesn't quite match
# the full signature of the update method in MutableMapping. But we ignore.
def update(self, update_dict: SupportsKeysAndGetItem[str, Any]) -> None: # type: ignore[override]
def update(self, update_dict: Mapping[str, Any]) -> None: # type: ignore[override]
for k in update_dict:
self._unsaved_values.add(k)

Expand Down
2931
0