8000 Parameter types by richardm-stripe · Pull Request #1078 · stripe/stripe-python · GitHub
[go: up one dir, main page]
Skip to content

Parameter types #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 13, 2023
Merged

Parameter types #1078

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
276ec9e
Add request options type
richardm-stripe Oct 11, 2023
816aff9
Update linter
richardm-stripe Oct 11, 2023
e95d8c9
Using Mapping, not Dict
richardm-stripe Oct 11, 2023
08ab763
Add param types
richardm-stripe Oct 11, 2023
8c8ac3e
change convention
richardm-stripe Oct 11, 2023
331be0a
lint rule update
richardm-stripe Oct 13, 2023
f158b75
Import from right place
richardm-stripe Oct 13, 2023
4901578
NotRequired[Optional[X]] -> NotRequired[X|None]
richardm-stripe Oct 13, 2023
4a8fa87
Use latest pyright again
richardm-stripe Oct 13, 2023
5b690ff
Merge branch 'richardm-use-latest-pyright-again' into richardm-params
richardm-stripe Oct 13, 2023
d177112
Print out pyright version
richardm-stripe Oct 13, 2023
e819083
Use a recent version of pyright, please
richardm-stripe Oct 13, 2023
40d0aee
Merge branch 'master' into richardm-params
richardm-stripe Oct 13, 2023
4ca8ea7
Run pyright for 3.6 on python 3.7
richardm-stripe Oct 13, 2023
df393ae
Forget the constraint
richardm-stripe Oct 13, 2023
dd7f863
Nest inside if TYPE_CHECKING
richardm-stripe Oct 13, 2023
67ffa53
Comment
richardm-stripe Oct 13, 2023
547c98b
Group TYPE_CHECKING with other imports
richardm-stripe Oct 13, 2023
< 10000 summary class="Link--muted select-menu-button" aria-haspopup="true" data-target="file-filter.summary"> File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use latest pyright again
  • Loading branch information
@richardm-stripe
richardm-stripe committed Oct 13, 2023
commit 4a8fa87a1fbf0aed8e8375bbc9b51a18aa2dd90b
2 changes: 0 additions & 2 deletions constraints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
# cryptography 40.0.0 deprecates support for Python 3.6 and PyPy3 < 7.3.10
cryptography<40
# TODO (remove later): pyright 1.1.323 introduces false positive errors
pyright<1.1.323
4 changes: 4 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ exclude = '''
)
'''
[tool.pyright]
executionEnvironments=[
{"root" = "stripe"}
]
include=["stripe"]
exclude=["build", "**/__pycache__"]
reportMissingTypeArgument=true
reportUnnecessaryCast=true
reportUnnecessaryComparison=true
Expand Down
0