10BC0 mock: caller information for unexpected method call by spirin · Pull Request #1644 · stretchr/testify · GitHub
[go: up one dir, main page]
Skip to content

mock: caller information for unexpected method call #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2024
Merged

mock: caller information for unexpected method call #1644

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea6964c
mock: caller information for unexpected method call
spirin Sep 30, 2024
d62ca68
tests
spirin Sep 30, 2024
f3f7181
Merge branch 'master' into unexpected-method-caller-info
spirin Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
mock: caller information for unexpected method call
  • Loading branch information
@spirin
spirin committed Sep 30, 2024
commit ea6964c2e96c2c682acc94781c71d861e21c94fc
3 changes: 2 additions & 1 deletion mock/mock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,11 +491,12 @@ func (m *Mock) MethodCalled(methodName string, arguments ...interface{}) Argumen
m.mutex.Unlock()

if closestCall != nil {
m.fail("\n\nmock: Unexpected Method Call\n-----------------------------\n\n%s\n\nThe closest call I have is: \n\n%s\n\n%s\nDiff: %s",
m.fail("\n\nmock: Unexpected Method Call\n-----------------------------\n\n%s\n\nThe closest call I have is: \n\n%s\n\n%s\nDiff: %s\nat: %s\n",
callString(methodName, arguments, true),
callString(methodName, closestCall.Arguments, true),
diffArguments(closestCall.Arguments, arguments),
strings.TrimSpace(mismatch),
assert.CallerInfo(),
)
} else {
m.fail("\nassert: mock: I don't know what to return because the method call was unexpected.\n\tEither do Mock.On(\"%s\").Return(...) first, or remove the %s() call.\n\tThis method was unexpected:\n\t\t%s\n\tat: %s", methodName, methodName, callString(methodName, arguments, true), assert.CallerInfo())
Expand Down
0