Refactor deprecated unittest aliases for Python 3.11 compatibility. #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @tirkarthi THANK YOU so much for this PR!! i noticed warnings when running the test suite because of this. @hozn if you happen to see this, this PR is a great one to merge as it's triggering a lot of warnings when running tests. |
|
@hozn are you comfortable with merging this one as well? i was starting to implement this when running the tests. it will fix some of the warnings we are getting. |
|
Yes, I'm comfortable with this one too. Thanks! |
|
great! @tirkarthi thank you - merging this!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated unittest aliases were removed in Python 3.11 . The recommended aliases are present in both Python 2.7 and Python 3. So the PR is backwards compatible.
assertEquals -> assertEqual
assertAlmostEquals -> assertAlmostEqual
Ref : python/cpython#28268