8000 chore(otel): raise exception if exporter unavailable by jer96 · Pull Request #234 · strands-agents/sdk-python · GitHub
[go: up one dir, main page]

Skip to content

chore(otel): raise exception if exporter unavailable #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

jer96
Copy link
Contributor
@jer96 jer96 commented Jun 16, 2025

Description

This is a followup to #232. After speaking with @zastrowm we agreed that it is better to explicitly raise an exception if a customer relies on Strand's internally configured OTEL HTTP exporter. The goal is to avoid a situation where a customer has deployed a Strands agent to production and after #232 their telemetry is no longer being exported. The overall blast radius of this change is minimal as outlined in #232.

Related Issues

Documentation PR

Planned for a separate PR. Tracking issue: https://github.com/strands-agents/private-sdk-python-staging/issues/76

Type of Change

  • Followup

Testing

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jer96 jer96 requested a review from zastrowm June 16, 2025 18:43
@jer96 jer96 assigned jer96 and unassigned zastrowm Jun 16, 2025
@jer96 jer96 marked this pull request as ready for review June 16, 2025 18:43
@jer96 jer96 merged commit e12bc2f into strands-agents:main Jun 16, 2025
10 of 30 checks passed
pgrayy pushed a commit to pgrayy/sdk-python that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0